Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search entities in the correct namespace #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Search entities in the correct namespace #23

wants to merge 1 commit into from

Commits on Apr 12, 2019

  1. Search entities in the correct namespace 

    Instead of assuming that all entities are in namespace 0 (which is only
true in a Wikidata-like installation, but not in a default Wikibase
installation, and even then only for items, not properties), take the
actual namespace of the requested entity from an injected
EntityNamespaceLookup.

Also, if we can’t find the entity, throw an exception instead of
returning count 0: it’s better to fail the import than to duplicate
statements.

Fixes filbertkm#22.
    @lucaswerkmeister
    lucaswerkmeister committed Apr 12, 2019
    Configuration menu
    Copy the full SHA
    307b44b View commit details
    Browse the repository at this point in the history