Update get device serial logic #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shrikant Temburwar <[email protected]>
Signed-off-by: Shrikant Temburwar <[email protected]>
Signed-off-by: Shrikant Temburwar <[email protected]>
…nt-sdk-fidoiot into update-dev-ser
Signed-off-by: Shrikant Temburwar <[email protected]>
KiranSukhavasi
previously approved these changes
Mar 14, 2024
KiranSukhavasi
approved these changes
Mar 14, 2024
DukeDavis12
approved these changes
Mar 14, 2024
v-vasavi
reviewed
Mar 14, 2024
| @@ -103,6 +103,7 @@ RETRY=false # Error Recovery disabled | |||
| Option to get device serial from system BIOS table: | |||
| GET_DEV_SERIAL=true # get device serial enabled | |||
| GET_DEV_SERIAL=false # get device serial disabled (default) | |||
| NOTE: linux-client required elevated privileges to get device serial from system BIOS table. Use 'sudo' to execute. | |||
There was a problem hiding this comment.
why is there a sudden need to use sudo?
There was a problem hiding this comment.
dmidecode -s system-serial-number is a linux command and it requires permissions to display system details.
Sudo is required to get a serial number from BIOS system. If sudo is not provided then it will take the default 'abcdef' serial number
|
Why are we using sudo now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update get device serial logic