#929 ecommerce goals for tests #933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArtemijRodionov
changed the title
ArtemijRodionov
commented
Jul 4, 2019
|
|
||
|
|
||
| class Goals(abc.ABC): | ||
| """Front-end reached goalss.""" |
duker33
approved these changes
Jul 5, 2019
|
|
||
| class YandexEcommerceGoals(Goals): | ||
| """ | ||
| Represent reached Yandex ecommerce goals. |
There was a problem hiding this comment.
it's not informative string. Let's rm it. Leave an ignore comment if py doc lint requires it
ArtemijRodionov
force-pushed
the
929-js-ecommerce-test-goals
branch
from
489dbbc to
b938c26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #929