Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests_js_analytics.py:91-95: Test Yandex ecommerce goals.... #808

Closed
0pdd opened this issue Apr 8, 2019 · 6 comments · Fixed by #919
Closed

tests_js_analytics.py:91-95: Test Yandex ecommerce goals.... #808

0pdd opened this issue Apr 8, 2019 · 6 comments · Fixed by #919
Assignees
@ArtemijRodionov
Labels
1 burning issue 2 hours some big and monolith issue with hard decisions, discussions or bug with strong research cleanup everything that do project stronger, flexible, reusable

Comments

@0pdd
Copy link
Collaborator

0pdd commented Apr 8, 2019

The puzzle 799-d8297b13 from #799 has to be resolved:

shopelectro/shopelectro/tests/tests_js_analytics.py

Lines 91 to 95 in 73af98b

# @todo #799:120m Test Yandex ecommerce goals.
# Here are goals left to test:
# - onCartClear from cart
# - onProductAdd from catalog, product and order pages
# - onProductRemove from cart and order page

The puzzle was created by Artemiy on 08-Apr-19.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
@0pdd
Copy link
Collaborator Author

0pdd commented Apr 8, 2019

@artemiyds2 @duker33 please pay attention to this new issue.

0pdd referenced this issue Apr 8, 2019
@ArtemijRodionov
#799 test yandex ecommerce (#800)
73af98b 
* Create ProductPage for selenium tests

* Create tests for product detail goal

* Create CartPosition element

* Update issue number for todo

* Create file with exceptions for elements

* Apply linter rules and review fixes
This was referenced Apr 8, 2019
Closed
Closed
Closed
Closed
Closed
@ArtemijRodionov ArtemijRodionov self-assigned this Apr 8, 2019
@ArtemijRodionov ArtemijRodionov added 1 burning issue 2 hours some big and monolith issue with hard decisions, discussions or bug with strong research cleanup everything that do project stronger, flexible, reusable labels Apr 8, 2019
@ArtemijRodionov ArtemijRodionov mentioned this issue Jun 30, 2019
Merged
ArtemijRodionov added a commit that referenced this issue Jun 30, 2019
@ArtemijRodionov
#808 test ecommerce analytics (#919)
5db3a86 
* Implement cart methods for tests

* Test cart clear event

* Test remove from cart event

* Wait adding of a product in product page

* Test ecommerce adding event

* Apply  review fixes

* Fix tests
This was referenced Jun 30, 2019
Closed
Closed
@0pdd
Copy link
Collaborator Author

0pdd commented Jun 30, 2019

@0pdd 2 puzzles #920, #921 are still not solved.

@ArtemijRodionov ArtemijRodionov mentioned this issue Jul 2, 2019
Merged
ArtemijRodionov added a commit that referenced this issue Jul 2, 2019
@ArtemijRodionov
#808 review fixes (#923)
de1fc9c 
* Apply review fixes

* Create todo to create Goals class

* Skip test_accordion_minimized
This was referenced Jul 2, 2019
Closed
Open
@0pdd
Copy link
Collaborator Author

0pdd commented Jul 2, 2019

@0pdd 4 puzzles #920, #921, #929, #930 are still not solved.

@0pdd
Copy link
Collaborator Author

0pdd commented Jul 5, 2019

@0pdd 3 puzzles #929, #930, #938 are still not solved; solved: #920, #921.

@0pdd
Copy link
Collaborator Author

0pdd commented Jul 5, 2019

@0pdd 3 puzzles #930, #938, #940 are still not solved; solved: #920, #921, #929.

@0pdd
Copy link
Collaborator Author

0pdd commented Jul 12, 2019

@0pdd 2 puzzles #930, #940 are still not solved; solved: #920, #921, #929, #938.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ArtemijRodionov ArtemijRodionov

Labels
1 burning issue 2 hours some big and monolith issue with hard decisions, discussions or bug with strong research cleanup everything that do project stronger, flexible, reusable
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#808 test ecommerce analytics fidals/shopelectro
2 participants
@ArtemijRodionov @0pdd