Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracking.es6:63-64: Create tests for eCommerce tracking.... #762

Closed
0pdd opened this issue Mar 7, 2019 · 13 comments
Closed

tracking.es6:63-64: Create tests for eCommerce tracking.... #762

0pdd opened this issue Mar 7, 2019 · 13 comments
Assignees
Labels
1 hour typical issue size. It's one pdd hour 1 burning issue blocker this issue blocks another issue front markup or work with js Ya eCommerce feature

Comments

@0pdd
Copy link
Collaborator

0pdd commented Mar 7, 2019

The puzzle 759-e8d84e6c from #759 has to be resolved:

// @todo #759:60m Create tests for eCommerce tracking.
// Test all events, these perform tracking operations.

The puzzle was created by Artemiy on 07-Mar-19.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

@0pdd
Copy link
Collaborator Author

0pdd commented Mar 7, 2019

@artemiyds2 @duker33 please pay attention to this new issue.

0pdd referenced this issue Mar 7, 2019
* Remove dangling todo

* Dispatch gtm_loaded event

* Create PublishedGATracker class for GATracker

* Fix typo

* Review fixes

* Move class declaration upper than instantiation

* Apply linter rules
@ArtemijRodionov ArtemijRodionov self-assigned this Mar 7, 2019
@ArtemijRodionov ArtemijRodionov added 1 hour typical issue size. It's one pdd hour 2 performer can implement issue at his closest convenient time Ya eCommerce feature front markup or work with js labels Mar 7, 2019
@ArtemijRodionov ArtemijRodionov added 1 burning issue blocker this issue blocks another issue and removed 2 performer can implement issue at his closest convenient time labels Mar 12, 2019
@ArtemijRodionov
Copy link
Contributor

I increased the priority, because it transitively blocks fixes of google eCommerce for STB

@ArtemijRodionov
Copy link
Contributor

first i'll create tests for google to unblock #761

@ArtemijRodionov
Copy link
Contributor

I want to use shopelectro.selenium classes for new tests, so i will do this issue with #764

ArtemijRodionov added a commit that referenced this issue Mar 14, 2019
* Make a mock of google analytics for tests.

* Use SiteDriver instead of seleniumrequests.Remote

* Fix SiteDriver instantiation

* Fix wait

* Create test for google ecommerce

* Remove Remote driver for mobile tests

* Disable celery for GoogleEcommerce test case

* Review fixes

* Apply linter rules
@0pdd
Copy link
Collaborator Author

0pdd commented Mar 14, 2019

@0pdd 2 puzzles #771, #772 are still not solved.

@0pdd
Copy link
Collaborator Author

0pdd commented Mar 20, 2019

@0pdd the puzzle #785 is still not solved; solved: #771, #772.

@0pdd
Copy link
Collaborator Author

0pdd commented Mar 31, 2019

@0pdd the puzzle #799 is still not solved; solved: #771, #772, #785.

@0pdd
Copy link
Collaborator Author

0pdd commented Apr 8, 2019

@0pdd 2 puzzles #807, #808 are still not solved; solved: #771, #772, #785, #799.

@0pdd
Copy link
Collaborator Author

0pdd commented Jun 30, 2019

@0pdd 3 puzzles #807, #920, #921 are still not solved; solved: #771, #772, #785, #799, #808.

@0pdd
Copy link
Collaborator Author

0pdd commented Jul 2, 2019

@0pdd 5 puzzles #807, #920, #921, #929, #930 are still not solved; solved: #771, #772, #785, #799, #808.

@0pdd
Copy link
Collaborator Author

0pdd commented Jul 5, 2019

@0pdd 4 puzzles #807, #929, #930, #938 are still not solved; solved: #771, #772, #785, #799, #808, #920, #921.

@0pdd
Copy link
Collaborator Author

0pdd commented Jul 5, 2019

@0pdd 4 puzzles #807, #930, #938, #940 are still not solved; solved: #771, #772, #785, #799, #808, #920, #921, #929.

@0pdd
Copy link
Collaborator Author

0pdd commented Jul 12, 2019

@0pdd 3 puzzles #807, #930, #940 are still not solved; solved: #771, #772, #785, #799, #808, #920, #921, #929, #938.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 hour typical issue size. It's one pdd hour 1 burning issue blocker this issue blocks another issue front markup or work with js Ya eCommerce feature
Projects
None yet
Development

No branches or pull requests

2 participants