-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tracking.es6:63-64: Create tests for eCommerce tracking.... #762
Labels
1 hour
typical issue size. It's one pdd hour
1
burning issue
blocker
this issue blocks another issue
front
markup or work with js
Ya eCommerce
feature
Comments
@artemiyds2 @duker33 please pay attention to this new issue. |
0pdd
referenced
this issue
Mar 7, 2019
* Remove dangling todo * Dispatch gtm_loaded event * Create PublishedGATracker class for GATracker * Fix typo * Review fixes * Move class declaration upper than instantiation * Apply linter rules
ArtemijRodionov
added
1 hour
typical issue size. It's one pdd hour
2
performer can implement issue at his closest convenient time
Ya eCommerce
feature
front
markup or work with js
labels
Mar 7, 2019
ArtemijRodionov
added
1
burning issue
blocker
this issue blocks another issue
and removed
2
performer can implement issue at his closest convenient time
labels
Mar 12, 2019
I increased the priority, because it transitively blocks fixes of google eCommerce for STB |
first i'll create tests for google to unblock #761 |
I want to use |
ArtemijRodionov
added a commit
that referenced
this issue
Mar 14, 2019
* Make a mock of google analytics for tests. * Use SiteDriver instead of seleniumrequests.Remote * Fix SiteDriver instantiation * Fix wait * Create test for google ecommerce * Remove Remote driver for mobile tests * Disable celery for GoogleEcommerce test case * Review fixes * Apply linter rules
This was referenced Mar 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
1 hour
typical issue size. It's one pdd hour
1
burning issue
blocker
this issue blocks another issue
front
markup or work with js
Ya eCommerce
feature
The puzzle
759-e8d84e6c
from #759 has to be resolved:shopelectro/front/js/shared/tracking.es6
Lines 63 to 64 in 987327e
The puzzle was created by Artemiy on 07-Mar-19.
If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
The text was updated successfully, but these errors were encountered: