Skip to content

Commit

Permalink
#844 Fix breadcrumbs markup (#845)
Browse files Browse the repository at this point in the history
* Fix breadcrumbs markup. Create related todo

* Fix pdd task format
  • Loading branch information
ArtemijRodionov authored May 17, 2019
1 parent 680649b commit fb70e0d
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion templates/pages/breadcrumbs_with_siblings.html
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
{% load pages_extras %}

{% comment %} @todo #844:60m Add a html validator to CI pipeline{% endcomment %}

<div class="hidden-xs hidden-sm breadcrumbs-wrapper"
itemscope itemtype="https://schema.org/BreadcrumbList">
{% for name, url, siblings in crumbs_list %}
{% if url %}
<span class="breadcrumbs-item" itemprop="itemListElement" itemscope itemtype="https://schema.org/ListItem">
<a href="{{ base_url }}{{ url }}" itemprop="item" class="breadcrumbs-link">
class="breadcrumbs-link">
<span itemprop="name">{{ name }}</span>
</a>

Expand Down

1 comment on commit fb70e0d

@0pdd
Copy link
Collaborator

@0pdd 0pdd commented on fb70e0d May 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Puzzle 844-220eaf83 discovered in templates/pages/breadcrumbs_with_siblings.html and submitted as #849. Please, remember that the puzzle was not necessarily added in this particular commit. Maybe it was added earlier, but we discovered it only now.

Please sign in to comment.