Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Clippies about partial_cmp() #201

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Fix Clippies about partial_cmp() #201

merged 1 commit into from
Oct 23, 2023

Conversation

arendjr
Copy link
Contributor

@arendjr arendjr commented Oct 23, 2023

Looks like newer Clippy versions are more strict about the implementation of PartialOrd. If the type also implements Ord, partial_cmp() must defer to cmp() to guarantee consistent behavior.

@arendjr arendjr requested a review from a team as a code owner October 23, 2023 14:40
@arendjr arendjr merged commit 95bb9ce into main Oct 23, 2023
2 checks passed
@arendjr arendjr deleted the partial_cmp_fixes branch October 23, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hatchan hatchan hatchan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arendjr @hatchan