Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rules for adding slice_wavs #347

Merged
merged 3 commits into from
Jan 20, 2025
Merged

Add rules for adding slice_wavs #347

merged 3 commits into from
Jan 20, 2025

Conversation

Pasarus
Copy link
Member

@Pasarus Pasarus commented Jan 14, 2025

Closes #345

Description

Add rules for supporting taking values from the DB and allowing users to dynamically change how many and what sectors are reduced.

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 93.18%. Comparing base (d5cd219) to head (99987fa).

Files with missing lines Patch % Lines
rundetection/rules/factory.py 50.00% 2 Missing ⚠️
rundetection/rules/common_rules.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #347      +/-   ##
==========================================
- Coverage   93.52%   93.18%   -0.34%     
==========================================
  Files          14       14              
  Lines         772      778       +6     
==========================================
+ Hits          722      725       +3     
- Misses         50       53       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Pasarus Pasarus merged commit dbe49a6 into main Jan 20, 2025
2 checks passed
@Pasarus Pasarus deleted the add_rule_for_slice_wavs branch January 20, 2025 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make default_slice_wavs customizable in script for SANs
2 participants