Use API to get specifications #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #343 +/- ##
==========================================
+ Coverage 93.22% 93.75% +0.52%
==========================================
Files 14 14
Lines 723 736 +13
==========================================
+ Hits 674 690 +16
+ Misses 49 46 -3 ☔ View full report in Codecov by Sentry. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
HumzahJavid
reviewed
Dec 9, 2024
HumzahJavid
reviewed
Dec 9, 2024
Dagonite
reviewed
Dec 9, 2024
Dagonite
reviewed
Dec 9, 2024
Dagonite
reviewed
Dec 9, 2024
Dagonite
requested changes
Dec 9, 2024
HumzahJavid
reviewed
Dec 11, 2024
HumzahJavid
reviewed
Dec 11, 2024
Dagonite
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #291
Description
Use the API to get the specification for rundetection. Currently tested on staging and hard to test manually, recommend just code review.