Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Encoding::UndefinedConversionError #19

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix Encoding::UndefinedConversionError #19

wants to merge 1 commit into from

Conversation

S-YOU
Copy link

@S-YOU S-YOU commented Jan 5, 2018

If the source code or comments has unicode characters, (and may be in some ruby versions),
rcov_result.encoding results in #Encoding:ASCII-8BIT, but OS encoding is UTF-8, and
conversion happens before file write, and which in turn results in error.

~/.rbenv/versions/2.5.0/lib/ruby/gems/2.5.0/gems/simplecov-rcov-0.2.3/lib/simplecov-rcov.rb:53:in `write': "\xE4" from ASCII-8BIT to UTF-8 (Encoding::UndefinedConversionError)

@vincentjiang
Copy link

@S-YOU
I meet this problem too.

gems/simplecov-rcov-0.2.3/lib/simplecov-rcov.rb:52:in `write': "\xE8" from ASCII-8BIT to UTF-8 (Encoding::UndefinedConversionError)

@brightball
Copy link

Same problem.

@vincentjiang
Copy link

@fguillen Please review and fix the bug.

@k0kubun k0kubun mentioned this pull request Apr 13, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincentjiang vincentjiang vincentjiang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@S-YOU @vincentjiang @brightball