Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core): use agent identifier in almanac attestation #603

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

jrriehl
Copy link
Contributor

@jrriehl jrriehl commented Jan 8, 2025

Proposed Changes

In order to for the Almanac API to know whether an agent is registered on testnet or mainnet, it need to have access to the full prefixed agent identifier (test-agent://agent1..., agent://agent1...), not just the agent address.

Linked Issues

#520

Types of changes

What type of change does this pull request make (put an x in the boxes that apply)?

  • Bug fix (non-breaking change that fixes an issue).
  • New feature added (non-breaking change that adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to stop working as expected).
  • Documentation update.
  • Something else (e.g., tests, scripts, example, deployment, infrastructure).

Checklist

Put an x in the boxes that apply:

  • I have read the CONTRIBUTING guide
  • Checks and tests pass locally

If applicable

  • I have added tests that prove my fix is effective or that my feature works
  • I have added/updated the documentation (executed the script in python/scripts/generate_api_docs.py)

@jrriehl jrriehl marked this pull request as ready for review January 8, 2025 14:48
@jrriehl jrriehl mentioned this pull request Jan 8, 2025
9 tasks
Copy link
Member

@Archento Archento left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
We just need to remember checking for compatibility with the inspector as the return value in the REST endpoint has changed.

@jrriehl jrriehl merged commit b482043 into main Jan 9, 2025
9 checks passed
@jrriehl jrriehl deleted the chore/use-agent-identifier-in-almanac-attestation branch January 9, 2025 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants