Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deny-all adapter for socket imports #2971

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Fix deny-all adapter for socket imports #2971

merged 1 commit into from
Dec 19, 2024

Conversation

fibonacci1729
Copy link
Contributor

Fixes #2969

lann
lann reviewed Dec 19, 2024
View reviewed changes
Copy link
Collaborator

@lann lann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but since we paired on the fix another set of eyes would be good

itowlson
itowlson approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@itowlson itowlson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but since I am as ignorant as apples... grin

Should we do a 3.1 patch for this?

@fibonacci1729
Copy link
Contributor Author

Yes a patch makes sense. I can't get to it today but I can cut a release tomorrow morning.

@fibonacci1729 fibonacci1729 merged commit 26ff330 into fermyon:main Dec 19, 2024
17 checks passed
@fibonacci1729 fibonacci1729 deleted the fix-deny-adapter branch December 19, 2024 22:32
@fibonacci1729 fibonacci1729 mentioned this pull request Dec 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lann lann lann left review comments

@itowlson itowlson itowlson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Better error messages when component dependencies are not allowed to inherit configuration
3 participants
@fibonacci1729 @lann @itowlson