Azure Cosmos multiple stores per container #2953
Open
+109
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Levick <[email protected]>
Signed-off-by: Ryan Levick <[email protected]>
calebschoepp
approved these changes
Dec 18, 2024
| Ok(Arc::new(AzureCosmosStore { | ||
| client: self.client.clone(), | ||
| partition_key: self.app_id.as_ref().map(|i| format!("{i}/{name}")), |
There was a problem hiding this comment.
If app_id is None will this incorrectly leave a leading forward slash in the partition key?
There was a problem hiding this comment.
I see below that it seems like the leading slash is okay, but I'll leave the question here to double check.
Comment on lines
+245
to
+258
| fn get_query(&self) -> String { | ||
| let mut query = format!("SELECT * FROM c WHERE c.id='{}'", self.key); | ||
| self.append_partition_key(&mut query); | ||
| query | ||
| } | ||
|
|
||
| fn append_partition_key(&self, query: &mut String) { | ||
| if let Some(pk) = &self.partition_key { | ||
| query.push_str(" AND c.partition_key='"); | ||
| query.push_str(pk); | ||
| query.push('\'') | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Why are these redefined here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2951
This adds support in the Azure Cosmos key-value implementation for storing multiple key-value stores in a single Azure Cosmos container.
IMPORTANT: This currently does not change the Spin CLI experience at all. Users of Spin CLI continue to have the 1 to 1 relationship between containers and key-value stores. This only allows Spin runtime embedders the ability to have many stores per containers. We can consider changing the default behavior for the Spin CLI in the future, but this might need to be at a major version change.
For embedders who provide an
app_idto theKeyValueAzureCosmos, stores will be created in the supplied container and each key/value pair will include a partition_key field in the form of "$app_id/$store_id".cc @devigned