Error if generating bindings for non-existent component #14

itowlson · 2024-12-12T19:04:03Z

Fixes #13.

$ spin deps generate-bindings -L rust -o bindywoo -c nonexistentcomp
Error: The WIT file that `spin deps` uses to track component dependencies doesn't exist. This can happen if:
* the component name is incorrect
* you've not previously run `spin deps add` for this component
The expected file is ".wit/components/nonexistentcomp/deps.wit"

Signed-off-by: itowlson <[email protected]>

mikkelhegn · 2024-12-13T09:39:47Z

src/commands/bindings.rs

@@ -34,8 +34,12 @@ impl GenerateBindingsCommand {
            .join(SPIN_DEPS_WIT_FILE_NAME);

        if !std::fs::exists(&wit_path)? {
-            // TODO: warn that the file does not exist


Error if generating bindings for non-existent component

f0f2317

Signed-off-by: itowlson <[email protected]>

itowlson requested review from fibonacci1729, mikkelhegn and karthik2804 December 12, 2024 19:04

fibonacci1729 approved these changes Dec 12, 2024

View reviewed changes

itowlson merged commit ecaf069 into fermyon:main Dec 12, 2024
8 checks passed

mikkelhegn reviewed Dec 13, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Error if generating bindings for non-existent component #14

Error if generating bindings for non-existent component #14

itowlson commented Dec 12, 2024

mikkelhegn Dec 13, 2024

Error if generating bindings for non-existent component #14

Error if generating bindings for non-existent component #14

Conversation

itowlson commented Dec 12, 2024

mikkelhegn Dec 13, 2024

Choose a reason for hiding this comment