Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update testing-apps.md #1401

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Update testing-apps.md #1401

merged 1 commit into from
Oct 29, 2024

Conversation

petersalomonsen
Copy link
Contributor

correct spin.toml for component.my-component.tool.spin-test dir should be workdir

Content must go through a pre-merge checklist.

Pre-Merge Content Checklist

This documentation has been checked to ensure that:

  • The title, template, and date are all set
  • Does this PR have a new menu item (anywhere in templates/*.hbs files) that points to a document .md that is set to publish in the future? If so please only publish the .md and .hbs changes in real-time (otherwise there will be a menu item pointing to a .md file that does not exist)
  • File does not use CRLF, but uses plain LF (hint: use cat -ve <filename> | grep $'\r' | wc -l and expect 0 as a result)
  • Has passed bart check
  • Has been manually tested by running in Spin/Bartholomew (hint: use PREVIEW_MODE=1 and run npm run styles to update styling)
  • Headings are using Title Case
  • Code blocks have the programming language set to properly highlight syntax and the proper copy directive
  • Have tested with npm run test and resolved all errors
  • Relates to an existing (potentially outdated) blog article? If so please add URL in blog to point to this content.

correct spin.toml for `component.my-component.tool.spin-test`
`dir` should be `workdir`


Signed-off-by: Peter Salomonsen <[email protected]>
Copy link
Member

@vdice vdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @petersalomonsen!

@itowlson
Copy link
Contributor

CI error is unrelated broken links, which are fixed in the v3 PR. Thank you @petersalomonsen!

@itowlson itowlson merged commit 1ce2fcc into fermyon:main Oct 29, 2024
2 of 3 checks passed
@petersalomonsen petersalomonsen deleted the patch-1 branch November 1, 2024 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants