Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unwrap base URL and minor styling #189

Merged
merged 2 commits into from
May 5, 2024
Merged

Unwrap base URL and minor styling #189

merged 2 commits into from
May 5, 2024

Conversation

garikAsplund
Copy link
Contributor

Before:
Screenshot 2024-05-03 at 3 17 52 PM
After:
Screenshot 2024-05-03 at 3 16 51 PM

@garikAsplund
Unwrap base URL and minor styling
88478b3 
Signed-off-by: Garik Asplund <[email protected]>
@garikAsplund
ran cargo fmt again
36df135 
Signed-off-by: Garik Asplund <[email protected]>
@garikAsplund
Copy link
Contributor Author

From looking at the build logs it appears that there's an extra line in my code--not sure if that's there after I rancargo fmt or not. Sorry for the small hangup.

itowlson
itowlson approved these changes May 5, 2024
View reviewed changes
Copy link
Contributor

@itowlson itowlson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice - thanks!

@itowlson itowlson merged commit d85b5e5 into fermyon:main May 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itowlson itowlson itowlson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@garikAsplund @itowlson