add voetbal-nl #582
Merged
add voetbal-nl #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello 👋 thank you for taking the time to contribute! May I ask you to remove all node updates (pnpm and dockerfile) from this PR, as we have a method for updating both ferdium-app and ferdium-recipes together? Thank you! |
vraravam
requested changes
Sep 5, 2024
There was a problem hiding this comment.
I agree with @SpecialAro - please remove the node and pnpm upgrades from this PR
|
I'm sorry, I wasn't aware there was a method to keep the recipes in sync with the app. I removed the Node and docker updates from this PR. |
richardbeumer
changed the title
vraravam
requested changes
Sep 5, 2024
vraravam
requested changes
Sep 5, 2024
add voetbal-nl; update pnpm and docker version revert docker and package settings remove package-lock.json; remove .pnpm-store remove all.json revert .gitignore
|
squashed all commits to one for now. |
vraravam
approved these changes
Sep 5, 2024
|
@all-contributors please add @richardbeumer for code |
|
@richardbeumer already contributed before to code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-flight Checklist
Please ensure you've completed all of the following.
Description of Change
Add voetbal-nl recipe