chore: change icons to reduce bundle #537
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-flight Checklist
Please ensure you've completed all of the following.
Description of Change
After some discussion with @vraravam we came to the conclusion that SVG increase local bundle size for users, which is unnecessary given users can fetch the static assets generated by
jsdelivr
.Indeed, before this PR total package bundle of all recipes was 7.34 MB and now it is 377 KB, which is ~19.5 times smaller.
To test this PR do the following:
recipes
submodule and add myferdium-recipes
fork as a remotepnpm i
andpnpm package
%AppData%/Ferdium/recipes
) and manually bring the version down of each recipepackage.json
What to expect:
%AppData%/Ferdium/recipes/{recipeId}
folder should be automatically deleted.This PR needs to be merged before the one on the main repo (ferdium/ferdium-app#1740).