Fix selectors for Nextcloud Talk recipe #470
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Script and CSS was updated to add selectors for the latest Nextcloud (27). Previous selectors were left as is for backwards compatibility. Additionally direct notifications count now is detected by unread conversations count in the left sidebar, using Talk specific notifications as a fallback. Fixes ferdium-app/#971
1 task
|
This looks great codewise, but I can't verify this as I am not using Nextcloud Task. Deferring to other contributors. |
eandersons
changed the title
|
Sorry, I accidentally deleted the wrong branch. I recreated the branch |
|
Oh too bad! Unfortunately, the GitHub interace tells me that I can't reopen the PR because it was recreated. |
This was referenced Nov 28, 2023
|
Duplicate of #473 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-flight Checklist
Please ensure you've completed all of the following.
Description of Change
Script and CSS was updated to add selectors for the latest Nextcloud (27).
Previous selectors were left as is for backwards compatibility.
Additionally direct notifications count now is detected by unread conversations count in the left sidebar, using Talk specific notifications as a fallback.
Fixes ferdium/ferdium-app#971