Fix Zoho Mail badge #466
Merged
Fix Zoho Mail badge #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As `window.zmNCenter` which was used to get notifications count for the badge's indirect notifications part does not exist anymore, badge for Zoho Mail was not working. The solution was to retrieve notifications count differently and to exclude Zoho Mail specific `window` properties from the `if` condition so the badge would be affected only partially if one of the used Zoho Mail `window` properties gets removed. For example, if `zmTopBar` will be removed from `window`, retrieval of the direct messages count would still work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-flight Checklist
Please ensure you've completed all of the following.
Description of Change
As
window.zmNCenterwhich was used to get notifications count for the badge's indirect notifications part does not exist anymore, badge for Zoho Mail was not working.The solution was to retrieve notifications count differently and to exclude Zoho Mail specific
windowproperties from theifcondition so the badge would be affected only partially if one of the used Zoho Mailwindowproperties gets removed in the future. For example, ifzmTopBarwill be removed fromwindow, retrieval of the direct messages count wouldstill work.
Additionally unread chats count was added to Zoho Mail badge's direct notifications.