-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Google Voice recipe add darkmode.css, fix message counts #449
Conversation
Hey @oc013, thanks for this great contribution! Make sure to update the |
@mcmxcdev thanks for taking a look. I bumped the version number as you pointed out. Does this approach seem reasonable? I'm not entirely clear why the normal dark mode/dark reader doesn't apply for this service, so this feels a bit like a brute force with all the I'll try to address the file upload and settings screen later today to make this PR a bit more complete. |
It's a good question, I am unfortunately not too familiar with how darkreader works in our codebase. Pretty sure even darkreader would need to resort to !important overrides, since their styles need to have higher CSS specifity. |
Are you still planning on making these changes? Otherwise, we can get this merged already. |
I added classes for the settings page. I'm not able to style the image upload picker as far as I can tell because it's an iframe coming from docs.google.com instead of voice.google.com. Probably as far as I'll take this for now :) |
Ready to go, added a few last minute changes. Most notably fixed the unread message count. |
Thanks @oc013 for helping out! |
@all-contributors please add @oc013 for code |
I've put up a pull request to add @oc013! 🎉 I've put up a pull request to add @mcmxcdev! 🎉 |
Pre-flight Checklist
Please ensure you've completed all of the following.
Description of Change
Fixes ferdium/ferdium-app#1005
Dark mode has never worked in my recollection for Google Voice. Please accept my humble submission to save our collective night vision.
This covers the main areas of the google voice site, (calls, voicemails, texts, settings) but not image uploads/attachments as that view is in a remote iframe.
Updated webview.js to correctly count messages, calls and voicemails for the service badge count.