Update Messenger link handling #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am not using FB Messenger so I am unable to review this PR unfortunately. Can anyone else from @ferdium/reviewers jump in and verify? |
|
I wonder if, whilst we're in this area, we can somehow filter out where FB injects tracking elements into links, and/or a pre-check link that sends you first to messenger.com before the real link ? I've seen a few scripts/plugins that do this elsewhere .. but is it something that is worth incorporating in Ferdium too? |
|
@mjeveritt Feel free to open an issue for it in https://github.com/ferdium/ferdium-app, then that feature be prioritized. It shouldn't extend the scope of the current PR. |
Arthur-Huan
force-pushed
the
messenger-beta
branch
from
bd74153 to
7ce40f0
Compare
2 tasks
Alphrag
force-pushed
the
messenger-beta
branch
from
7ce40f0 to
96e2e64
Compare
Alphrag
approved these changes
Nov 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-flight Checklist
Please ensure you've completed all of the following.
Description of Change