Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add memos recipe #445

Merged
merged 2 commits into from
Nov 2, 2023
Merged

Conversation

lincolnthalles
Copy link
Contributor

Pre-flight Checklist

Please ensure you've completed all of the following.

Description of Change

Add recipe for memos

@SpecialAro
Copy link
Member

Hi @lincolnthalles !

Thank you for logging this PR 😁

Just to clarify:

  • Memos is self-hosted only, right? Meaning there is no "official" app rather than the demo?

If that is the case then let me suggest trying to change the package.json to something like the Slack recipe (that includes teamId and the teamIdSuffix). Can we test if making teamIdSuffix empty and the URL the full teamId works?

This way users will be forced to indicate a URL. Otherwise, if that doesn't work, we can keep it like is 😁

Let me know if you prefer that I test my suggestion on my side first!

@lincolnthalles
Copy link
Contributor Author

Hi @lincolnthalles !

Thank you for logging this PR 😁

Just to clarify:

  • Memos is self-hosted only, right? Meaning there is no "official" app rather than the demo?

If that is the case then let me suggest trying to change the package.json to something like the Slack recipe (that includes teamId and the teamIdSuffix). Can we test if making teamIdSuffix empty and the URL the full teamId works?

This way users will be forced to indicate a URL. Otherwise, if that doesn't work, we can keep it like is 😁

Let me know if you prefer that I test my suggestion on my side first!

It's self-hosted only, the domain can be anything. So, there's no point in using the subdomain template from Slack.
By just removing serviceURL Ferdium will require user to input a URL.

@mcmxcdev mcmxcdev merged commit 1f2ef43 into ferdium:main Nov 2, 2023
@mcmxcdev
Copy link
Member

mcmxcdev commented Nov 2, 2023

Thanks for the added recipe @lincolnthalles !

@Alphrag
Copy link
Member

Alphrag commented Nov 5, 2023

@all-contributors please add @lincolnthalles for code

Copy link
Contributor

@Alphrag

I've put up a pull request to add @lincolnthalles! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants