comments

felipenoris · Sep 25, 2018 · 9f64fb8 · 9f64fb8
1 parent 5ef7a3a
commit 9f64fb8
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/README.md b/README.md
@@ -90,14 +90,14 @@ by calling `rustdylib_free_rust_owned_string`, to let the memory be freed.
 pub extern fn rustdylib_generate_rust_owned_string() -> *mut c_char {
     let rust_string = String::from("The bomb: 💣");
     let cstring = CString::new(rust_string).unwrap();
-    cstring.into_raw()
+    cstring.into_raw() // transfers ownership to the Julia process
 }
 
 #[no_mangle]
 pub extern fn rustdylib_free_rust_owned_string(s: *mut c_char) {
     unsafe {
         if s.is_null() { return }
-        CString::from_raw(s)
+        CString::from_raw(s) // retakes ownership of the CString
     };
 }
 ```

diff --git a/deps/RustDylib/src/lib.rs b/deps/RustDylib/src/lib.rs
@@ -72,13 +72,13 @@ pub extern fn rustdylib_inspect_string(cstring: *const c_char) {
 pub extern fn rustdylib_generate_rust_owned_string() -> *mut c_char {
     let rust_string = String::from("The bomb: 💣");
     let cstring = CString::new(rust_string).unwrap();
-    cstring.into_raw()
+    cstring.into_raw() // transfers ownership to the Julia process
 }
 
 #[no_mangle]
 pub extern fn rustdylib_free_rust_owned_string(s: *mut c_char) {
     unsafe {
         if s.is_null() { return }
-        CString::from_raw(s)
+        CString::from_raw(s) // retakes ownership of the CString
     };
 }