Added dkim2 and dmarc #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
He Joe,
Something was wrong with de DKIM2 property, so i added a JsonProperty attribute to fix it.
After creating PR the test pipeline went wrong, because the API key is not filled.
Can you complete the PR and update the nuget?
#233
[https://opengraph.githubassets.com/1ad505c0e09ae0256b344d866d87e84092e4ccf26450814b87300548accea8d2/feinoujc/Mandrill.net/pull/233]<https://github.com/feinoujc/Mandrill.net/pull/233>
Added JsonProperty for DKIM2 to map properly by pieter61 · Pull Request #233 · feinoujc/Mandrill.net<#233>
Mailchimp Transactional (Mandrill) api client for .NET - Added JsonProperty for DKIM2 to map properly by pieter61 · Pull Request #233 · feinoujc/Mandrill.net
github.com
Best regards,
Pieter de Jong
…________________________________
Van: Joe Feinour ***@***.***>
Verzonden: vrijdag 16 februari 2024 14:49
Aan: feinoujc/Mandrill.net ***@***.***>
CC: pieter61 ***@***.***>; Author ***@***.***>
Onderwerp: Re: [feinoujc/Mandrill.net] Added dkim2 and dmarc (PR #220)
@feinoujc approved this pull request.
Thanks!
—
Reply to this email directly, view it on GitHub<#220 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADNO7EVV3USGP5Z4IZTRCZTYT5PWDAVCNFSM6AAAAABDKPQWN2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQOBVGIYDGOBTGI>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.