-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Move srpm/rpm build to packit #1820
Conversation
Also call sed just once. This will make the next step easier.
@zpytela , @WOnder93 : The packit tasks don't start here as you didn't yet enable packit on the selinux-policy project: https://packit.dev/docs/guide#github . This is just a few clicks. I tested this in martinpitt#1 , see the statuses on martinpitt@edb6506 . This will allow you to drop in tmt test plans, which will then run for upstream PRs and also Fedora/RHEL gating. In martinpitt#2 I staged the next step, which would run cockpit's tests on selinux-policy PRs to get some more regression testing. Please let me know if you have any question. However, I will be on PTO for two weeks starting tomorrow, so please feel free to ask @jelly or @marusak - they can also help you. Thanks! |
Whoops, sorry, I accidentally pushed to your branch - now undone. |
Split off make-sources.sh from make-srpm.sh which builds a directory with the sprm ingredients (the unpacked directory); the packit workflow requires that, it builds the srpm by itself after some further adjustments. This mostly obsoletes the need of doing custom COPR builds, so eventually .copr/ can be simplified. But keep the old functionality for the time being. Note that this way of building an srpm in packit is still rather unusual: the normal mode is to maintain the .spec and all auxiliary files in the upstream git; that then enables automatic Fedora releases, and make it easier to keep the spec in sync. But one step after another.. Configure packit to automatically build srpm and rpms in the usual temporary COPRs. This makes it much easier to test PRs both by humans and future integration tests. There are no test plans yet, but already enable the TF run to at least cover package installation/upgrade. Run these on Rawhide and the current stable Fedora (38 right now). This entirely replaces the "build-rpm" workflow, so drop that. Co-Authored-By: Ondrej Mosnacek <[email protected]>
fbfa187
to
a571063
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks a lot!
Merging, thank you. |
You merged this prematurely -- the packit build didn't actually run yet, you need to enable packit for the "fedora-selinux" scenario. See comment above: #1820 (comment) |
You are right, the next steps need to agree with some conditions, so I will proceed later. |
Split off make-sources.sh from make-srpm.sh which builds a directory
with the sprm ingredients (the unpacked directory); the packit workflow
requires that, it builds the srpm by itself after some further
adjustments.
This mostly obsoletes the need of doing custom COPR builds, so
eventually .copr/ can be simplified. But keep the old functionality for
the time being.
Note that this way of building an srpm in packit is still rather
unusual: the normal mode is to maintain the .spec and all auxiliary
files in the upstream git; that then enables automatic Fedora releases,
and make it easier to keep the spec in sync. But one step after
another..
Configure packit to automatically build srpm and rpms in the usual
temporary COPRs. This makes it much easier to test PRs both by humans
and future integration tests. There are no test plans yet, but already
enable the TF run to at least cover package installation/upgrade.
Run these on Rawhide and the current stable Fedora (38 right now).
This entirely replaces the "build-rpm" workflow, so drop that.
Co-Authored-By: Ondrej Mosnacek [email protected]