Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow systemd_network_generator_t notify systemd manager #1785

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

zpytela
Copy link
Contributor

@zpytela zpytela commented Jul 18, 2023

Allow systemd-network-generator send system log messages

Logging support for the network generator was added by systemd commit
8b24bcdfa8 ("network-generator: Add missing log_setup()",
systemd/systemd@8b24bcdfa8).

Resolves: rhbz#2223571

@zpytela zpytela force-pushed the sd-network-gen branch 2 times, most recently from f3d6266 to 9466978 Compare July 18, 2023 15:23
@WOnder93
Copy link
Member

The description doesn't seem to be correct... The denial in the BZ is for the journald socket and another one for /dev/kmsg (I assume this one only pops up as a fallback after the first one is denied). I believe the right interface for that is logging_send_syslog_msg().

@keszybz
Copy link
Contributor

keszybz commented Jul 18, 2023

Yeah, the description doesn't seem to agree with the patch. systemd-network-generator does not use Type=notify-reload.

I think systemd/systemd@8b24bcd is the culprit. Simply speaking, logging was broken, and now we started logging. It probably tries to log to the journal, but gets a denial, and falls back to kmsg.

Logging support for the network generator was added by systemd commit
8b24bcdfa8 ("network-generator: Add missing log_setup()",
systemd/systemd@8b24bcdfa8).

Resolves: rhbz#2223571
@zpytela
Copy link
Contributor Author

zpytela commented Jul 21, 2023

Thank you both for the review, I apparently followed an incorrect lead written in oneof the reports and subsequently mismatched the problem with another one, still this was a draft PR where things can happen.

@zpytela zpytela marked this pull request as ready for review July 21, 2023 15:34
@zpytela zpytela merged commit 2c0b0e5 into fedora-selinux:rawhide Jul 21, 2023
2 checks passed
@zpytela zpytela deleted the sd-network-gen branch July 21, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants