fix: trim base64 input before attempting decryption #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the decryption input is base64-encoded, we can safely trim
leading and trailing whitespace from it.
If the input has a newline, it will fail validation, e.g:
```
jwe="$(echo "foobar" | clevis-pin-tpm2 encrypt {})"
echo "${jwe}" | clevis-pin-tpm2 decrypt
Error: Error decrypting JWE
Caused by:
0: Invalid JWE format: Invalid byte 10, offset 22.
1: Invalid byte 10, offset 22.
```
Also include additional integration tests written in shell script.
Signed-off-by: Sergio Correia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the decryption input is base64-encoded, we can safely trim leading and trailing whitespace from it.
If the input has a newline, it will fail validation, e.g:
Also include additional integration tests written in shell script.