Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed #944 : Ask for camera permission before launching gallery #953

Closed
wants to merge 1 commit into from

Conversation

akashs056
Copy link

Added Methods like

  • checkCameraPermission
  • requestCameraPermission

And requested permision from the user to take photos or record vedios

…gallery

Added Methods like
- checkCameraPermission
- requestCameraPermission

And requested permision from the user to take photos or record vedios
@federicoiosue
Copy link
Owner

Hi there!

Great job, but this needs a couple of refinements:

  • Try improving a litthe bit the code formatting

    private static final int FILES = 7;
    private static final int CAMERA_PERMISSION_REQUEST_CODE =8 ;
  • Be sure no other actions can break your flow: you currently covered the case when a user tries to take a picture/video from a note's detail view, and in this situation the user is prompted permission. But things breaks down when you try to get a picture directly from the notes' list shortcut

    Omni-Notes_–AndroidManifest_xml__Omni-Notes_omniNotes_main

@pratistha-05
Copy link

pratistha-05 commented Jan 23, 2024

I have fixed this issue and working fine, please check my PR
#955

@federicoiosue
Copy link
Owner

Closed with #955 thanks for the contribution to both of you, you've been credited into the changelog for the latest version of the app!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants