Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(updater): triage all monitor messages based on success/failure #631

Merged
merged 5 commits into from
Nov 4, 2023

Conversation

favonia
Copy link
Owner

@favonia favonia commented Nov 4, 2023

No description provided.

Copy link

codecov bot commented Nov 4, 2023

Codecov Report

Merging #631 (dd1eed4) into main (1d51ef1) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #631      +/-   ##
==========================================
+ Coverage   88.45%   88.50%   +0.05%     
==========================================
  Files          45       45              
  Lines        2330     2341      +11     
==========================================
+ Hits         2061     2072      +11     
  Misses        259      259              
  Partials       10       10              
Flag Coverage Δ
unittests 88.50% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
internal/config/network_probe.go 74.28% <100.00%> (ø)
internal/updater/updater.go 100.00% <100.00%> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@favonia favonia force-pushed the triage-all-monitor-messages branch from c63e8db to ad2fc28 Compare November 4, 2023 19:34
Copy link

sonarqubecloud bot commented Nov 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@favonia favonia merged commit b23ba55 into main Nov 4, 2023
10 checks passed
@favonia favonia deleted the triage-all-monitor-messages branch November 4, 2023 21:29
@favonia favonia added this to the 1.12.0 milestone Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant