Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update comments about Uptime Kuma #625

Merged
merged 1 commit into from
Oct 24, 2023
Merged

docs: update comments about Uptime Kuma #625

merged 1 commit into from
Oct 24, 2023

Conversation

favonia
Copy link
Owner

@favonia favonia commented Oct 24, 2023

100% close #616.

@favonia favonia added this to the 1.12.0 milestone Oct 24, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #625 (3e2256c) into main (a9bce5c) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #625      +/-   ##
==========================================
+ Coverage   88.44%   88.46%   +0.01%     
==========================================
  Files          45       45              
  Lines        2329     2332       +3     
==========================================
+ Hits         2060     2063       +3     
  Misses        259      259              
  Partials       10       10              
Flag Coverage Δ
unittests 88.46% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
internal/monitor/uptimekuma.go 95.69% <100.00%> (+0.14%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@favonia
Copy link
Owner Author

favonia commented Oct 24, 2023

Wow I didn't know that comments count towards coverage testing... 🤯

@favonia favonia merged commit 4ecf073 into main Oct 24, 2023
12 checks passed
@favonia favonia deleted the update-comment branch October 24, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent Uptime Kuma from showing "OK" for failures
1 participant