Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pp): make some hints visible in the quiet mode #1015

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

favonia
Copy link
Owner

@favonia favonia commented Jan 10, 2025

Close #1004. Close #1005. Close #1014. Close #967.

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 89.13043% with 5 lines in your changes missing coverage. Please review.

Project coverage is 94.72%. Comparing base (44462f4) to head (ac56f45).

Files with missing lines Patch % Lines
internal/pp/fmt.go 81.25% 2 Missing and 1 partial ⚠️
internal/pp/queued.go 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1015      +/-   ##
==========================================
- Coverage   94.94%   94.72%   -0.23%     
==========================================
  Files          62       62              
  Lines        3366     3375       +9     
==========================================
+ Hits         3196     3197       +1     
- Misses        158      165       +7     
- Partials       12       13       +1     
Flag Coverage Δ
unittests 94.72% <89.13%> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@favonia favonia force-pushed the make-warnings-visible branch from ac56f45 to 05a1f4d Compare January 13, 2025 04:26
@favonia
Copy link
Owner Author

favonia commented Jan 13, 2025

TODO: avoid duplicate warnings for the same values

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant