Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation and daemon installer for discovery node #1010

Merged
merged 10 commits into from
Nov 4, 2024

Conversation

noursaidi
Copy link
Collaborator

No description provided.

@noursaidi noursaidi requested a review from grafnu October 30, 2024 21:35
@@ -0,0 +1 @@
venv/*
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just venv/ -- no need for the trailing star


`sudo ~/venv/bin/python3 main.py`
`vendor` discovery family is a counter which increments every second
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't make sense?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just a note to say that if the discovery node does a vendor discovery is actually a counter

 for i in itertools.count(1):
      if self.cancelled:
        return
      result = DiscoveryEvent(
          generation=self.generation, scan_family=self.scan_family, scan_addr=i
      )
      self.publisher(result)
      time.sleep(1)

```json
{
"mqtt": {
"device_id": "GAT-1",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indent


```json
{
"mqtt": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be dandy if this bit matched the schema of schema/configuration_endpoint.json -- but, we can track that with some future work. That's fundamentally what this is...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, I do agree with that and something I plan to do

@noursaidi noursaidi merged commit 0f5030f into faucetsdn:master Nov 4, 2024
4 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants