Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some TODO cleanup #3491

Merged
merged 1 commit into from
Jun 29, 2020
Merged

Some TODO cleanup #3491

merged 1 commit into from
Jun 29, 2020

Conversation

mab68
Copy link
Contributor

@mab68 mab68 commented Mar 16, 2020

This goes with #3490

@gizmoguy
Copy link
Member

+#977

@codecov
Copy link

codecov bot commented Mar 17, 2020

Codecov Report

Merging #3491 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3491      +/-   ##
==========================================
+ Coverage   92.32%   92.33%   +0.01%     
==========================================
  Files          46       46              
  Lines        8256     8253       -3     
==========================================
- Hits         7622     7620       -2     
+ Misses        634      633       -1     
Impacted Files Coverage Δ
faucet/faucet_dot1x.py 92.27% <ø> (ø)
faucet/faucet_event.py 63.86% <ø> (ø)
faucet/fctl.py 83.93% <ø> (ø)
faucet/prom_client.py 97.78% <ø> (ø)
faucet/valve.py 93.35% <ø> (ø)
faucet/vlan.py 96.40% <ø> (ø)
faucet/dp.py 95.71% <100.00%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92c7b22...8742027. Read the comment docs.

@mab68 mab68 changed the title WIP: TODO cleanup Some TODO cleanup Jun 22, 2020
@anarkiwi anarkiwi merged commit 8087e04 into faucetsdn:master Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants