Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Vivado Accelerator missing partition factor variable #1160

Merged

Conversation

bo3z
Copy link
Contributor

@bo3z bo3z commented Jan 7, 2025

Description

📝 Fixes the missing maximum_size variable for the partition_factor in Vivado Accelerator backend

Type of change

  • Bug fix (non-breaking change that fixes an issue)

Tests

None yet; still needs confirmation that it fixes the issue confirmed in #1157

Checklist

  • I have read the guidelines for contributing.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have installed and run pre-commit on the files I edited or added.
  • I have added tests that prove my fix is effective or that my feature works.

@bo3z bo3z added the please test Trigger testing by creating local PR branch label Jan 7, 2025
@JanFSchulte JanFSchulte merged commit 4b7e12d into fastmachinelearning:main Jan 7, 2025
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
please test Trigger testing by creating local PR branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants