Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower dependency version and delete Cargo.lock #69

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Conversation

harmony7
Copy link
Contributor

@harmony7 harmony7 commented Mar 4, 2024

This PR lowers the dependency version of fastly crate to ^0.9.0 and removes Cargo.lock.

In a starter kit, we should declare a version of the SDK that has the features needed (^0.9 in this case), as well as dependencies. And by not including Cargo.lock, the user always gets the newest compatible version at the time their project is initialized, and a new lock file that they would commit to their new project's code repo.

@harmony7 harmony7 requested a review from kpfleming March 4, 2024 07:11
@harmony7 harmony7 requested a review from a team as a code owner March 4, 2024 07:11
@harmony7 harmony7 requested review from aturon and removed request for a team March 4, 2024 07:11
@harmony7 harmony7 merged commit 5ae2f71 into main Mar 6, 2024
1 check passed
@harmony7 harmony7 deleted the kats/dependencies branch March 6, 2024 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants