Lower dependency version and delete Cargo.lock #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harmony7
requested review from
a team and
triblondon
and removed request for
a team
acfoltzer
approved these changes
Mar 5, 2024
There was a problem hiding this comment.
I feel a little strange about not bounding the minimum version with the most current release, given that bugs have been fixed in the SDK since 0.9.0. However, unless the user pulls in another crate with an older fastly dependency, cargo is going to resolve to the new version anyway.
Just to make sure, I validated that the template builds even with the dependency fixed to =0.9.0, so I don't think there's a clear risk of breakage with this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR lowers the dependency version of fastly crate to
^0.9.0and removesCargo.lock.In a starter kit, we should declare a version of the SDK that has the features needed (^0.9 in this case), as well as dependencies. And by not including
Cargo.lock, the user always gets the newest compatible version at the time their project is initialized, and a new lock file that they would commit to their new project's code repo.