Add get_addr_dest_{ip,port} hostcalls
#402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulyssa
force-pushed
the
ulyssa/backend-ip-addr
branch
from
416f605 to
6a1d87a
Compare
elliottt
reviewed
Jul 4, 2024
lib/src/upstream.rs
Outdated
| } | ||
|
|
||
| impl Connection { | ||
| fn metadata(&self) -> ConnMetadata { |
There was a problem hiding this comment.
I have a mild preference for returning a &ConnMetadata here and pushing the clone to the callsite, but given that this isn't exported beyond this module I could go either way.
Done in 270928a. I've added a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
get_addr_dest_ipandget_addr_dest_porthostcalls which will be part of the upcoming SDK release. They allow getting the IP and port used to connect to a backend from theResponseHandle.There is a difference in behaviour here worth calling out: in Compute, this is only currently supported when using
.set_pass(true)on theRequest. Since Viceroy doesn't have any concept of caching/direct pass at the moment, I wasn't sure whether I should add enough code to check whether the guest code had at least requested direct pass or not, and limit support so that things match what applications deployed to Compute will see.