Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependencies across directories #415

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

mcollina
Copy link
Member

@mcollina mcollina commented Oct 8, 2024

Fixes a regression introduced in #401 where dependencies across different prefixes were not taken into account.

Copy link
Contributor

@jean-michelet jean-michelet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but is it possible to write a test that proves the bug is fixed? And to avoid same regression in the future?

@mcollina
Copy link
Member Author

mcollina commented Oct 8, 2024

Looks good, but is it possible to write a test that proves the bug is fixed? And to avoid same regression in the future?

It's covered by moving the file plugin-d.js as you can see in the diff.

Signed-off-by: Matteo Collina <[email protected]>
@jean-michelet
Copy link
Contributor

Ok, missed it.

@mcollina mcollina merged commit 630bc84 into master Oct 8, 2024
13 checks passed
@mcollina mcollina deleted the fix-dependencies-across-directories branch October 8, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants