manage user permissions #514
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @dwradcliffe , just wanted to check in. Did you want me to review your PR, or is it still under development? |
AnalogJ
reviewed
Oct 9, 2024
Comment on lines
+216
to
+223
| user.Permissions = make(map[string]map[string]bool) | ||
|
|
||
| for _, acl := range acls { | ||
| if _, exists := user.Permissions[acl.TargetUserID.String()]; !exists { | ||
| user.Permissions[acl.TargetUserID.String()] = make(map[string]bool) | ||
| } | ||
| user.Permissions[acl.TargetUserID.String()][string(acl.Permission)] = true | ||
| } |
There was a problem hiding this comment.
Ideally this would be done with GORM Associations -- so we could use a single query.
https://gorm.io/docs/create.html#Create-With-Associations
https://gorm.io/docs/query.html#Joins-Preloading
AnalogJ
reviewed
Oct 9, 2024
| if result.Error != nil { | ||
| return result.Error | ||
| } | ||
| // Update User Permissions |
There was a problem hiding this comment.
ideally this would all be handed by the GORM Association logic & hooks
AnalogJ
reviewed
Oct 9, 2024
| Picture string `json:"picture"` | ||
| Email string `json:"email"` | ||
| Role pkg.UserRole `json:"role"` | ||
| Permissions map[string]map[string]bool `json:"permissions" gorm:"-:all"` |
There was a problem hiding this comment.
can we use GORM references for this - https://gorm.io/docs/has_many.html#Override-References
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #57
This adds the ability for an admin user to set permissions for each user. This does not allow these permissions to be used, that will be in the next PR.