Skip to content

Commit

Permalink
Merge pull request #1426 from dienhoa/fix_nb-name
Browse files Browse the repository at this point in the history
Fix exporting notebook names in notebooks 01 -> 04
  • Loading branch information
jph00 authored Jul 26, 2024
2 parents 2833d74 + 39bb3ba commit ea935f5
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion nbs/api/01_config.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -791,7 +791,7 @@
"path = Path('../nbdev')\n",
"(path/'config.py').unlink(missing_ok=True)\n",
"\n",
"_basic_export_nb(\"config.ipynb\", 'config.py')\n",
"_basic_export_nb(\"01_config.ipynb\", 'config.py')\n",
"\n",
"g = exec_new('from nbdev import config')\n",
"assert g['config'].add_init\n",
Expand Down
4 changes: 2 additions & 2 deletions nbs/api/02_maker.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -781,8 +781,8 @@
"add_init(path)\n",
"cfg = get_config()\n",
"\n",
"_basic_export_nb2('config.ipynb', 'config')\n",
"_basic_export_nb2('maker.ipynb', 'maker')\n",
"_basic_export_nb2('01_config.ipynb', 'config')\n",
"_basic_export_nb2('02_maker.ipynb', 'maker')\n",
"\n",
"g = exec_import('nbdev', 'maker')\n",
"assert g['maker'].ModuleMaker\n",
Expand Down
6 changes: 3 additions & 3 deletions nbs/api/03_process.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -634,9 +634,9 @@
"source": [
"#|eval: false\n",
"#|hide\n",
"_basic_export_nb2('config.ipynb', 'read')\n",
"_basic_export_nb2('maker.ipynb', 'maker')\n",
"_basic_export_nb2('process.ipynb', 'process')\n",
"_basic_export_nb2('01_config.ipynb', 'read')\n",
"_basic_export_nb2('02_maker.ipynb', 'maker')\n",
"_basic_export_nb2('03_process.ipynb', 'process')\n",
"\n",
"g = exec_new('import nbdev.process')\n",
"assert hasattr(g['nbdev'].process, 'NBProcessor')"
Expand Down
2 changes: 1 addition & 1 deletion nbs/api/04_export.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,7 @@
"source": [
"#|eval: false\n",
"Path('../nbdev/export.py').unlink(missing_ok=True)\n",
"nb_export('04a_export.ipynb')\n",
"nb_export('04_export.ipynb')\n",
"\n",
"g = exec_new('import nbdev.export')\n",
"assert hasattr(g['nbdev'].export, 'nb_export')"
Expand Down

0 comments on commit ea935f5

Please sign in to comment.