Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query transaction rework #4498

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

knighthat
Copy link

Is it me or OneColumnApp.kt and ThreeColumnsApp.kt are giving error because InnerTube#player doesn't have pipedSession?

@fast4x
Copy link
Owner

fast4x commented Nov 12, 2024

I don't remember, I'll check it soon

@twistios
Copy link

OneColumnApp and ThreeColumnsApp are not used by the android version of RiMusic.

@knighthat
Copy link
Author

Yea but now it's throwing errors

@twistios
Copy link

Yea but now it's throwing errors

How can it throw errors if it is not used?

@fast4x
Copy link
Owner

fast4x commented Nov 12, 2024

I'll check it before merge this

@fast4x fast4x added the WAIT label Nov 14, 2024
@knighthat
Copy link
Author

Yea but now it's throwing errors

How can it throw errors if it is not used?

it's linting error, because Innertube.Player with pipedSession as a parameter doesn't exist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants