Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phone numbers should be optional #16

Closed
Tracked by #2
tlater-famedly opened this issue Aug 2, 2024 · 2 comments · Fixed by #13
Closed
Tracked by #2

Phone numbers should be optional #16

tlater-famedly opened this issue Aug 2, 2024 · 2 comments · Fixed by #13
Assignees
Labels
bug Something isn't working

Comments

@tlater-famedly
Copy link
Contributor

Currently, phone numbers are mandatory, however it appears that this is was not the intended design.

@tlater-famedly tlater-famedly added the bug Something isn't working label Aug 2, 2024
@tlater-famedly tlater-famedly self-assigned this Aug 2, 2024
@tlater-famedly
Copy link
Contributor Author

Implementation in #13

I realized I never clarified if phone numbers should be optional at a configuration or at an individual-entry level, hence I'm opening this issue to track that.

Currently #13 implements it assuming it should be optional at a configuration level. This means that we will still refuse to sync entries without phone numbers if the tool has a phone attribute set, and never sync phone numbers if it there is no phone attribute.

@nikzen
Copy link

nikzen commented Aug 2, 2024

Implementation in #13

I realized I never clarified if phone numbers should be optional at a configuration or at an individual-entry level, hence I'm opening this issue to track that.

Currently #13 implements it assuming it should be optional at a configuration level. This means that we will still refuse to sync entries without phone numbers if the tool has a phone attribute set, and never sync phone numbers if it there is no phone attribute.

The tool should always sync the entry. If there is a phone number, it should include the number if not, it should sync what is there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants