Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(.github/workflow): strict naming convention for changed rules files #248

Merged
merged 1 commit into from
May 22, 2024

Conversation

leogr
Copy link
Member

@leogr leogr commented May 22, 2024

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind feature

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area rules

/area registry

/area build

/area documentation

Proposed rule maturity level

Uncomment one (or more) /area <> lines (only for PRs that add or modify rules):

/area maturity-stable

/area maturity-incubating

/area maturity-sandbox

/area maturity-deprecated

What this PR does / why we need it:

This PR aims to address the CI problem discovered in this PR.

The "Validate rules file" job wrongly assumed all files under /rules :point_down. However, we have to deal with the possibility that other legitimate files may be stored under that folder.

2024-05-20T14:20:44+0000: Falco version: 0.38.0-275+dfbd181 (x86_64)
2024-05-20T14:20:44+0000: CLI args: /usr/bin/falco -o json_output=true -V rules/OWNERS -o log_level=debug -o log_stderr=true -o log_syslog=false -o stdout_output.enabled=true
2024-05-20T14:20:44+0000: Falco initialized with configuration files:
2024-05-20T14:20:44+0000:    /etc/falco/falco.yaml
2024-05-20T14:20:44+0000: System info: Linux version 6.5.0-1021-azure (buildd@lcy02-amd[64](https://github.com/falcosecurity/rules/actions/runs/9160120617/job/25182147619?pr=247#step:6:65)-097) (x86_64-linux-gnu-gcc-11 (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0, GNU ld (GNU Binutils for Ubuntu) 2.38) #22~22.04.1-Ubuntu SMP Tue Apr 30 16:08:18 UTC 2024
2024-05-20T14:20:44+0000: Validating rules file(s):
2024-05-20T14:20:44+0000:    rules/OWNERS
2024-05-20T14:20:44+0000: closing inspectors
Error: rules/OWNERS: Invalid
1 Errors:
In rules content: (rules/OWNERS:0:0)
------
approvers:
^
------
LOAD_ERR_YAML_VALIDATE (Error validating internal structure of YAML file): Rules content is not yaml array of objects

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@poiana poiana added kind/bug Something isn't working dco-signoff: yes kind/documentation Improvements or additions to documentation area/build labels May 22, 2024
@poiana poiana requested review from darryk10 and Kaizhe May 22, 2024 09:38
Copy link
Contributor

@darryk10 darryk10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks Leo

@poiana
Copy link

poiana commented May 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: darryk10, leogr, LucaGuerra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 9e56293 into main May 22, 2024
7 of 8 checks passed
@poiana poiana deleted the leogr-patch-1 branch May 22, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/build dco-signoff: yes kind/bug Something isn't working kind/documentation Improvements or additions to documentation lgtm size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants