Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(rules): cleanup k8s.gcr.io #236

Merged
merged 1 commit into from
Mar 14, 2024
Merged

update(rules): cleanup k8s.gcr.io #236

merged 1 commit into from
Mar 14, 2024

Conversation

leogr
Copy link
Member

@leogr leogr commented Mar 14, 2024

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind feature

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area rules

/area registry

/area build

/area documentation

Proposed rule maturity level

Uncomment one (or more) /area <> lines (only for PRs that add or modify rules):

/area maturity-stable

/area maturity-incubating

/area maturity-sandbox

/area maturity-deprecated

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

cc @cpanato @LucaGuerra

Signed-off-by: Leonardo Grasso <[email protected]>
@poiana poiana requested a review from Kaizhe March 14, 2024 08:33
@poiana poiana added the area/maturity-stable See the Rules Maturity Framework label Mar 14, 2024
@poiana poiana requested a review from loresuso March 14, 2024 08:33
@poiana poiana added area/maturity-incubating See the Rules Maturity Framework approved area/maturity-sandbox See the Rules Maturity Framework size/S labels Mar 14, 2024
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

Rules files suggestions

falco_rules.yaml

Comparing b322a8e832b39fb41214208b7945185f88e86de6 with latest tag falco-rules-3.0.1

Patch changes:

  • List falco_privileged_images has some item added or removed

falco-incubating_rules.yaml

Comparing b322a8e832b39fb41214208b7945185f88e86de6 with latest tag falco-incubating-rules-3.0.1

Patch changes:

  • List falco_privileged_images has some item added or removed

falco-sandbox_rules.yaml

Comparing b322a8e832b39fb41214208b7945185f88e86de6 with latest tag falco-sandbox-rules-3.0.1

Patch changes:

  • List user_known_k8s_ns_kube_system_images has some item added or removed
  • List bpf_profiled_binaries has some item added or removed

@poiana
Copy link

poiana commented Mar 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, leogr, LucaGuerra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit fbf0a4e into main Mar 14, 2024
11 checks passed
@poiana poiana deleted the cleanup/k8s-gcr-io branch March 14, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants