Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(build/registry): allow optional auth to update-index cmd #219

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

brennoo
Copy link
Contributor

@brennoo brennoo commented Jan 22, 2024

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind feature

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area rules

/area registry

/area build

/area documentation

Proposed rule maturity level

Uncomment one (or more) /area <> lines (only for PRs that add or modify rules):

/area maturity-stable

/area maturity-incubating

/area maturity-sandbox

/area maturity-deprecated

What this PR does / why we need it:

Hi team, this PR allows to authenticate to the registry during update-index if the credentials are set

Which issue(s) this PR fixes:
This is not an issue for the public repository but we are relying on the registry tool to build/push our private repo indexes and it needs authentication.

Fixes #

Special notes for your reviewer:

@LucaGuerra
Copy link
Contributor

Thank you for this PR! The env variables are consistent with the push command so we can definitely merge this. However, while you absolutely can use our code in your workflow, please note that the build tool is technically part of the rules CI/CD process and it is not a tool that we are looking to support for general use, this means that we may break those interfaces or change the meaning of the commands without release notes or breaking change notices;

For general use cases I would recommend looking into the falcoctl command line tool if that fits the use you have in mind. If not, feedback (and contributions!) are appreciated to make it easier to use for CI/CD processes.

Again, thanks for the contribution! 🚀

@poiana
Copy link

poiana commented Jan 29, 2024

LGTM label has been added.

Git tree hash: f2d66e6844f07d0c34504b860ad65e0a6d6de223

@poiana
Copy link

poiana commented Jan 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brennoo, LucaGuerra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 3f668d0 into falcosecurity:main Jan 29, 2024
7 checks passed
@brennoo brennoo deleted the feat/auth_support_update_index branch July 18, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants