Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(auth/gcp): ensure correct OAuth scope for Artifact Registry with service account #659

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

evict
Copy link

@evict evict commented Nov 7, 2024

Adjusted OAuth scope to https://www.googleapis.com/auth/cloud-platform for compatibility with both service account and Workload Identity setups, resolving invalid scope errors when accessing Artifact Registry.

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

/kind flaky-test

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area library

/area cli

/area tests

/area examples

What this PR does / why we need it:
This PR fixes an issue with OAuth authentication when accessing Google Artifact Registry using a service account. By ensuring the correct scope (https://www.googleapis.com/auth/cloud-platform) is specified, this update resolves token retrieval errors and makes the authentication process compatible with both service account and Workload Identity configurations. This fix is essential for smooth integration with Artifact Registry, especially in environments leveraging Workload Identity on GKE.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

…service account

Adjusted OAuth scope to `https://www.googleapis.com/auth/cloud-platform` for compatibility with both service account and Workload Identity setups, resolving invalid scope errors when accessing Artifact Registry.
@poiana
Copy link
Contributor

poiana commented Nov 7, 2024

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

📝 Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

  • 84a18c6 fix(auth/gcp): ensure correct OAuth scope for Artifact Registry with service account

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@poiana poiana requested a review from alacuku November 7, 2024 12:08
@poiana
Copy link
Contributor

poiana commented Nov 7, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: evict
Once this PR has been reviewed and has the lgtm label, please assign cpanato for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana requested a review from zuc November 7, 2024 12:08
@poiana
Copy link
Contributor

poiana commented Nov 7, 2024

Welcome @evict! It looks like this is your first PR to falcosecurity/falcoctl 🎉

@poiana poiana added the size/XS label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants