Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(typing): type response #2304

Merged
merged 16 commits into from
Sep 20, 2024
Merged

feat(typing): type response #2304

merged 16 commits into from
Sep 20, 2024

Conversation

CaselIT
Copy link
Member

@CaselIT CaselIT commented Aug 26, 2024

follow up of #2299

falcon/middleware.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (9f47efb) to head (3b88210).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #2304   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           63        63           
  Lines         7539      7591   +52     
  Branches      1281      1281           
=========================================
+ Hits          7539      7591   +52     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vytas7 vytas7 changed the title Type response feat(typing): type request Aug 30, 2024
@vytas7 vytas7 changed the title feat(typing): type request feat(typing): type response Aug 30, 2024
@CaselIT
Copy link
Member Author

CaselIT commented Sep 10, 2024

@vytas7 updated

@CaselIT
Copy link
Member Author

CaselIT commented Sep 10, 2024

@vytas7 regarding the failure to install rapidjson in pypy, did you already had a fix in a PR?

@vytas7
Copy link
Member

vytas7 commented Sep 10, 2024

@vytas7 regarding the failure to install rapidjson in pypy, did you already had a fix in a PR?

Yes, but that PR still needs work, it is in Draft: https://github.com/falconry/falcon/pull/2324/files#diff-493968368d3cc25459cbc290f4f38ee1444eb298e0c5f840672c3dfce9b9f291R26.

@CaselIT
Copy link
Member Author

CaselIT commented Sep 10, 2024

will cherry pick b4a6a4d

@CaselIT
Copy link
Member Author

CaselIT commented Sep 10, 2024

seems to be working. pipeline should now be green

Copy link
Member

@vytas7 vytas7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good for the most of it, thanks!
As discussed, I want to privatize some things related to typing, but we can take a stab at that in a bit more systematic fashion in the cleanup issue.

@vytas7 vytas7 merged commit ddff2ce into falconry:master Sep 20, 2024
37 checks passed
@CaselIT CaselIT deleted the type_response branch September 20, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants