-
-
Notifications
You must be signed in to change notification settings - Fork 950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(typing): type response #2304
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2304 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 63 63
Lines 7539 7591 +52
Branches 1281 1281
=========================================
+ Hits 7539 7591 +52 ☔ View full report in Codecov by Sentry. |
@vytas7 updated |
@vytas7 regarding the failure to install rapidjson in pypy, did you already had a fix in a PR? |
Yes, but that PR still needs work, it is in Draft: https://github.com/falconry/falcon/pull/2324/files#diff-493968368d3cc25459cbc290f4f38ee1444eb298e0c5f840672c3dfce9b9f291R26. |
will cherry pick b4a6a4d |
seems to be working. pipeline should now be green |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good for the most of it, thanks!
As discussed, I want to privatize some things related to typing, but we can take a stab at that in a bit more systematic fashion in the cleanup issue.
follow up of #2299