Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename FBPCPComponents.md to PCPComponents.md #468

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Rename FBPCPComponents.md to PCPComponents.md #468

wants to merge 3 commits into from

Conversation

robotal
Copy link

@robotal robotal commented Nov 29, 2022

Summary:
Part 3 of the changes to FBPCP documentation. It will rename the file https://github.com/facebookresearch/fbpcp/blob/main/docs/FBPCPComponents.md -> https://github.com/facebookresearch/fbpcp/blob/main/docs/PCPComponents.md

As it is a higher risk changes we hold off as it is not as important.

Differential Revision:
D41597613

LaMa Project: L416713

Tal Davidi and others added 3 commits November 29, 2022 15:22
@facebook-github-bot
Minor fixes to documentation
7ffb2a2 
Differential Revision: D41597612

fbshipit-source-id: 3f0acc2a5d37badcf6c465bbca55973ec85c7b97
@facebook-github-bot
Remove Facebook from project name (facebookresearch#445)
402d3aa 
Summary:
Pull Request resolved: facebookresearch#445

We are doing this as a result of an open issue on our github facebookresearch/fbpcf#415. I spoke to caseybeal and thayat who are ok with us just changing the name of the repositories and updating documentation with mentions of Facebook to Meta.

- Removing mention of Facebook in the title of the project
- Replacing Facebook -> Meta where relevant

Differential Revision: https://internalfb.com/D40161520

fbshipit-source-id: 53e8e5ef94524b35bde12c40ac291bb3cae341ed
@facebook-github-bot
Rename FBPCPComponents.md to PCPComponents.md
385bcd0 
Summary:
Part 3 of the changes to FBPCP documentation. It will rename the file https://github.com/facebookresearch/fbpcp/blob/main/docs/FBPCPComponents.md -> https://github.com/facebookresearch/fbpcp/blob/main/docs/PCPComponents.md

As it is a higher risk changes we hold off as it is not as important.

Differential Revision:
D41597613

LaMa Project: L416713

fbshipit-source-id: e4b4f5df103503ba2a2832c69f0fd4cbc8d15eb7
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported labels Nov 29, 2022
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D41597613

@facebook-github-bot
Copy link
Contributor

Hi @robotal!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robotal @facebook-github-bot