Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the parameter in ParallelEmbedding #1138

Closed
wants to merge 1 commit into from
Closed

Fix the parameter in ParallelEmbedding #1138

wants to merge 1 commit into from

Conversation

taowangcheng
Copy link

The parameter passing is wrong in ParallelEmbedding. It should be the same as that in class VocabParallelEmbedding.

self.max_norm = max_norm
This may be a typo error.

cc @ezyang @likethesky @myleott @froody @Celebio

@facebook-github-bot
Copy link

Hi @taowangcheng!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 23, 2023
@awgu
Copy link

awgu commented Sep 24, 2023

I think this is the same as #1132.

@taowangcheng taowangcheng closed this by deleting the head repository Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants